Skip to content

Commit

Permalink
Avoid use of href for tab navigation - breaks right click - bad UX
Browse files Browse the repository at this point in the history
  • Loading branch information
nealeu committed Jun 10, 2018
1 parent 39ec01b commit b161395
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion components/ca-nav.html
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,10 @@
ca-nav li:last-child {
border-bottom: 0;
}

ca-nav > nav > ul > li > a {
cursor: pointer;
}
</style>
<script>
define('ca-nav', ['create-element'], (createElement) => {
Expand Down Expand Up @@ -132,7 +136,8 @@

const link = createElement(li, 'a',
{
href: item.href,
// eslint-disable-next-line no-script-url
onclick: 'javascript:void(0)',
'data-action': 'loadCRUD',
'data-rel': rel,
'data-href': item.href
Expand Down

0 comments on commit b161395

Please sign in to comment.