Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve perf measurement precision (POC) #534

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mdjastrzebski
Copy link
Member

@mdjastrzebski mdjastrzebski commented Oct 21, 2024

Summary

Resolves #516

Test plan

Copy link

changeset-bot bot commented Oct 21, 2024

⚠️ No Changeset found

Latest commit: 919b01f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Oct 21, 2024

Performance Comparison Report

  • Current: HEAD (873ae99) - 2024-10-21 08:32:22Z
  • Baseline: main (fafc067) - 2024-10-21 08:31:34Z

Significant Changes To Duration

Name Type Duration Count
Other Component 10 render 64.8 ms → 52.0 ms (-12.8 ms, -19.7%) 🟢 4 → 4
Other Component 20 render 66.0 ms → 51.9 ms (-14.1 ms, -21.4%) 🟢 4 → 4
Other Component 10 legacy scenario render 66.1 ms → 51.7 ms (-14.4 ms, -21.7%) 🟢 4 → 4
Async Component render 103.7 ms → 81.4 ms (-22.3 ms, -21.5%) 🟢 7 → 7
Show details
Name Type Duration Count
Other Component 10 render Baseline
Mean: 64.8 ms
Stdev: 4.7 ms (7.3%)
Runs: 64 60 67 61 63 67 70 63 59 74
Warmup runs: 224

Current
Mean: 52.0 ms
Stdev: 0.8 ms (1.5%)
Runs: 52.2 52.1 51.9 51.9 51.4 51.7 51.5 54.0 51.4 52.1
Warmup runs: 67.1
Baseline
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4
Render issues:
- Initial updates: 1

Current
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4
Render issues:
- Initial updates: 1
Other Component 20 render Baseline
Mean: 66.0 ms
Stdev: 4.1 ms (6.2%)
Runs: 64 63 66 68 60 68 67 66 61 68 68 68 61 59 75 72 62 67 70 66
Warmup runs: 67

Current
Mean: 51.9 ms
Stdev: 0.9 ms (1.8%)
Runs: 52.8 52.4 52.2 52.0 54.3 51.8 53.0 51.5 51.5 51.3 51.1 51.6 51.0 51.1 50.9 53.4 50.8 51.4 51.6 51.6
Warmup runs: 51.9
Baseline
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4
Render issues:
- Initial updates: 1

Current
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4
Render issues:
- Initial updates: 1
Other Component 10 legacy scenario render Baseline
Mean: 66.1 ms
Stdev: 3.7 ms (5.6%)
Runs: 70 69 60 66 64 73 66 65 63 65
Warmup runs: 66

Current
Mean: 51.7 ms
Stdev: 0.3 ms (0.5%)
Runs: 52.1 51.8 51.8 51.4 51.7 51.6 51.8 52.1 51.6 51.4
Warmup runs: 52.0
Baseline
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4
Render issues:
- Initial updates: 1

Current
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4
Render issues:
- Initial updates: 1
Async Component render Baseline
Mean: 103.7 ms
Stdev: 5.1 ms (5.0%)
Runs: 99 107 109 105 98 104 99 105 98 113
Warmup runs: 99

Current
Mean: 81.4 ms
Stdev: 0.8 ms (1.0%)
Runs: 80.8 80.8 81.2 81.4 80.4 80.6 81.3 82.0 82.8 82.4
Warmup runs: 87.1
Baseline
Mean: 7
Stdev: 0 (0.0%)
Runs: 7 7 7 7 7 7 7 7 7 7
Render issues:
- Initial updates: 1

Current
Mean: 7
Stdev: 0 (0.0%)
Runs: 7 7 7 7 7 7 7 7 7 7
Render issues:
- Initial updates: 1

Meaningless Changes To Duration

Show entries
Name Type Duration Count
fib 30 function 38.5 ms → 38.4 ms (-0.1 ms, ±0.0%) 1 → 1
fib 31 function 62.1 ms → 62.1 ms (-0.0 ms, ±0.0%) 1 → 1
fib 32 function 100.6 ms → 100.8 ms (+0.3 ms, ±0.0%) 1 → 1
InitialRenders 1 render 0.8 ms → 0.8 ms (+0.0 ms, +4.2%) 2 → 2
InitialRenders 3 render 1.0 ms → 1.2 ms (+0.2 ms, +18.0%) 🔴 4 → 4
ManyRenderIssues render 1.3 ms → 1.4 ms (+0.1 ms, +4.3%) 5 → 5
RedundantUpdates render 1.4 ms → 0.8 ms (-0.6 ms, -40.4%) 🟢 2 → 2
Show details
Name Type Duration Count
fib 30 function Baseline
Mean: 38.5 ms
Stdev: 0.2 ms (0.4%)
Runs: 38.7 38.7 38.7 38.7 38.4 38.4 38.4 38.3 38.5 38.3
Warmup runs: 39.4

Current
Mean: 38.4 ms
Stdev: 0.1 ms (0.1%)
Runs: 38.4 38.5 38.3 38.4 38.3 38.4 38.3 38.4 38.4 38.5
Warmup runs: 39.0
Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
fib 31 function Baseline
Mean: 62.1 ms
Stdev: 1.9 ms (3.1%)
Runs: 62.2 62.1 62.1 62.1 58.0 62.1 62.2 62.4 66.1 62.1
Warmup runs: 62.2

Current
Mean: 62.1 ms
Stdev: 0.1 ms (0.1%)
Runs: 62.3 62.2 62.1 62.1 62.2 62.1 62.1 62.2 62.1 62.1
Warmup runs: 62.2
Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
fib 32 function Baseline
Mean: 100.6 ms
Stdev: 0.2 ms (0.2%)
Runs: 100.5 100.5 100.5 100.5 100.6 100.5 100.5 100.6 101.0 100.5
Warmup runs: 100.5

Current
Mean: 100.8 ms
Stdev: 1.0 ms (0.9%)
Runs: 100.6 100.5 103.5 100.4 100.5 100.5 100.7 100.7 100.5 100.5
Warmup runs: 100.5
Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
InitialRenders 1 render Baseline
Mean: 0.8 ms
Stdev: 0.4 ms (52.7%)
Runs: 1 1 0 1 0 1 1 1 1 1
Warmup runs: 2

Current
Mean: 0.8 ms
Stdev: 0.1 ms (8.0%)
Runs: 0.8 0.9 0.9 1.0 0.8 0.8 0.8 0.8 0.8 0.8
Warmup runs: 1.6
Baseline
Mean: 2
Stdev: 0 (0.0%)
Runs: 2 2 2 2 2 2 2 2 2 2
Render issues:
- Initial updates: 1

Current
Mean: 2
Stdev: 0 (0.0%)
Runs: 2 2 2 2 2 2 2 2 2 2
Render issues:
- Initial updates: 1
InitialRenders 3 render Baseline
Mean: 1.0 ms
Stdev: 0.5 ms (47.1%)
Runs: 1 0 1 1 1 1 1 2 1 1
Warmup runs: 1

Current
Mean: 1.2 ms
Stdev: 0.0 ms (2.0%)
Runs: 1.2 1.2 1.2 1.2 1.2 1.1 1.2 1.2 1.2 1.2
Warmup runs: 1.1
Baseline
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4
Render issues:
- Initial updates: 3

Current
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4
Render issues:
- Initial updates: 3
ManyRenderIssues render Baseline
Mean: 1.3 ms
Stdev: 0.7 ms (51.9%)
Runs: 1 2 1 0 1 2 2 2 1 1
Warmup runs: 2

Current
Mean: 1.4 ms
Stdev: 0.0 ms (1.9%)
Runs: 1.3 1.3 1.4 1.4 1.3 1.4 1.4 1.3 1.4 1.3
Warmup runs: 1.3
Baseline
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5
Render issues:
- Initial updates: 2
- Redundant updates: 2 (3, 4)

Current
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5
Render issues:
- Initial updates: 2
- Redundant updates: 2 (3, 4)
RedundantUpdates render Baseline
Mean: 1.4 ms
Stdev: 0.8 ms (60.2%)
Runs: 0 2 0 2 2 2 1 2 1 2
Warmup runs: 1

Current
Mean: 0.8 ms
Stdev: 0.0 ms (4.1%)
Runs: 0.9 0.9 0.8 0.8 0.8 0.8 0.8 0.8 0.8 0.9
Warmup runs: 0.8
Baseline
Mean: 2
Stdev: 0 (0.0%)
Runs: 2 2 2 2 2 2 2 2 2 2
Render issues:
- Redundant updates: 1 (1)

Current
Mean: 2
Stdev: 0 (0.0%)
Runs: 2 2 2 2 2 2 2 2 2 2
Render issues:
- Redundant updates: 1 (1)

Render Count Changes

There are no entries

Render Issues

Name Initial Updates Redundant Updates
Other Component 10 1 🔴 -
Other Component 10 legacy scenario 1 🔴 -
Other Component 20 1 🔴 -
Async Component 1 🔴 -
InitialRenders 1 1 🔴 -
InitialRenders 3 3 🔴 -
RedundantUpdates - 1 (1) 🔴
ManyRenderIssues 2 🔴 2 (3, 4) 🔴

Added Scenarios

There are no entries

Removed Scenarios

There are no entries

Generated by 🚫 dangerJS against 919b01f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[IMPROVEMENT] Precision clarification
1 participant