Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: markdown cleanup #525

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

refactor: markdown cleanup #525

wants to merge 6 commits into from

Conversation

mdjastrzebski
Copy link
Member

Summary

Test plan

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 29, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 65e1c52

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 29, 2024 •
edited
Loading

Performance Comparison Report

  • Current: HEAD (7c8e696) - 2024-10-19 21:19:04Z
  • Baseline: main (fafc067) - 2024-10-19 21:18:13Z

Warnings

  • 🟡 Baseline results files ".reassure/baseline.perf" does not exists. This warning should be ignored only if you are bootstapping perf test setup, otherwise it indicates invalid setup.

Significant Changes To Duration

There are no entries

Meaningless Changes To Duration

Show entries
Name Type Duration Count
Async Component render 107.4 ms → 110.8 ms (+3.4 ms, +3.2%) 7 → 7
fib 30 function 38.5 ms → 38.5 ms (-0.0 ms, ±0.0%) 1 → 1
fib 31 function 62.6 ms → 62.1 ms (-0.5 ms, -0.8%) 1 → 1
fib 32 function 101.1 ms → 100.7 ms (-0.4 ms, ±0.0%) 1 → 1
InitialRenders 1 render 1.0 ms → 1.1 ms (+0.1 ms, +10.0%) 2 → 2
InitialRenders 3 render 1.5 ms → 1.0 ms (-0.5 ms, -33.3%) 🟢 4 → 4
ManyRenderIssues render 1.2 ms → 1.7 ms (+0.5 ms, +41.7%) 🔴 5 → 5
RedundantUpdates render 1.4 ms → 1.1 ms (-0.3 ms, -21.4%) 🟢 2 → 2
Show details
Name Type Duration Count
Async Component render Baseline
Mean: 107.4 ms
Stdev: 2.9 ms (2.7%)
Runs: 111 104 106 108 105 111 107 103 109 110
Warmup runs: 117

Current
Mean: 110.8 ms
Stdev: 7.8 ms (7.0%)
Runs: 107 102 118 99 115 117 105 124 111 110
Warmup runs: 107		 Baseline
Mean: 7
Stdev: 0 (0.0%)
Runs: 7 7 7 7 7 7 7 7 7 7
Render issues:
- Initial updates: 1

Current
Mean: 7
Stdev: 0 (0.0%)
Runs: 7 7 7 7 7 7 7 7 7 7
Render issues:
- Initial updates: 1
fib 30 function Baseline
Mean: 38.5 ms
Stdev: 0.1 ms (0.3%)
Runs: 38.6 38.5 38.6 38.6 38.4 38.5 38.6 38.4 38.5 38.7
Warmup runs: 39.6

Current
Mean: 38.5 ms
Stdev: 0.0 ms (0.1%)
Runs: 38.4 38.5 38.5 38.5 38.6 38.5 38.5 38.5 38.5 38.5
Warmup runs: 35.7		 Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
fib 31 function Baseline
Mean: 62.6 ms
Stdev: 1.3 ms (2.0%)
Runs: 62.2 62.0 62.1 66.1 62.9 62.0 62.1 62.1 62.2 62.1
Warmup runs: 62.1

Current
Mean: 62.1 ms
Stdev: 0.0 ms (0.1%)
Runs: 62.1 62.1 62.1 62.1 62.1 62.1 62.1 62.1 62.1 62.1
Warmup runs: 57.6		 Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
fib 32 function Baseline
Mean: 101.1 ms
Stdev: 1.6 ms (1.6%)
Runs: 101.5 101.5 101.5 101.6 101.8 101.7 101.6 101.6 96.5 101.5
Warmup runs: 101.0

Current
Mean: 100.7 ms
Stdev: 1.6 ms (1.5%)
Runs: 100.4 100.4 100.4 96.5 101.6 101.5 101.5 101.5 101.5 101.5
Warmup runs: 100.5		 Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
InitialRenders 1 render Baseline
Mean: 1.0 ms
Stdev: 0.0 ms (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
Warmup runs: 1

Current
Mean: 1.1 ms
Stdev: 0.9 ms (79.6%)
Runs: 2 1 1 2 0 1 2 0 0 2
Warmup runs: 10		 Baseline
Mean: 2
Stdev: 0 (0.0%)
Runs: 2 2 2 2 2 2 2 2 2 2
Render issues:
- Initial updates: 1

Current
Mean: 2
Stdev: 0 (0.0%)
Runs: 2 2 2 2 2 2 2 2 2 2
Render issues:
- Initial updates: 1
InitialRenders 3 render Baseline
Mean: 1.5 ms
Stdev: 0.5 ms (35.1%)
Runs: 2 2 1 2 1 1 1 1 2 2
Warmup runs: 0

Current
Mean: 1.0 ms
Stdev: 0.7 ms (66.7%)
Runs: 1 2 2 1 1 1 1 0 1 0
Warmup runs: 2		 Baseline
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4
Render issues:
- Initial updates: 3

Current
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4
Render issues:
- Initial updates: 3
ManyRenderIssues render Baseline
Mean: 1.2 ms
Stdev: 0.4 ms (35.1%)
Runs: 1 2 1 1 1 1 1 1 2 1
Warmup runs: 2

Current
Mean: 1.7 ms
Stdev: 0.9 ms (55.8%)
Runs: 2 3 3 0 1 1 2 2 1 2
Warmup runs: 1		 Baseline
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5
Render issues:
- Initial updates: 2
- Redundant updates: 2 (3, 4)

Current
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5
Render issues:
- Initial updates: 2
- Redundant updates: 2 (3, 4)
RedundantUpdates render Baseline
Mean: 1.4 ms
Stdev: 0.7 ms (49.9%)
Runs: 1 0 1 2 2 1 2 2 1 2
Warmup runs: 1

Current
Mean: 1.1 ms
Stdev: 0.7 ms (67.1%)
Runs: 0 1 1 1 2 1 2 1 0 2
Warmup runs: 0		 Baseline
Mean: 2
Stdev: 0 (0.0%)
Runs: 2 2 2 2 2 2 2 2 2 2
Render issues:
- Redundant updates: 1 (1)

Current
Mean: 2
Stdev: 0 (0.0%)
Runs: 2 2 2 2 2 2 2 2 2 2
Render issues:
- Redundant updates: 1 (1)

Render Count Changes

There are no entries

Render Issues

Name Initial Updates Redundant Updates
InitialRenders 1 1 🔴 -
InitialRenders 3 3 🔴 -
RedundantUpdates - 1 (1) 🔴
ManyRenderIssues 2 🔴 2 (3, 4) 🔴
Async Component 1 🔴 -
Other Component 1 🔴 -
Other Component 20 run 1 🔴 -

Added Entries

Show entries
Name Type Duration Count
Other Component render 68.4 ms 4
Other Component 20 run render 68.2 ms 4
Show details
Name Type Duration Count
Other Component render Current
Mean: 68.4 ms
Stdev: 5.8 ms (8.5%)
Runs: 71 67 68 67 60 77 61 65 71 77
Warmup runs: 72		 Current
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4
Render issues:
- Initial updates: 1
Other Component 20 run render Current
Mean: 68.2 ms
Stdev: 4.6 ms (6.8%)
Runs: 71 62 66 68 66 75 68 69 65 73 68 65 73 63 80 70 65 64 70 62
Warmup runs: 65		 Current
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4
Render issues:
- Initial updates: 1

Removed Entries

Show entries
Name Type Duration Count
Other Component 10 render 64.7 ms 4
Other Component 10 legacy scenario render 66.7 ms 4
Other Component 20 render 68.4 ms 4
Show details
Name Type Duration Count
Other Component 10 render Baseline
Mean: 64.7 ms
Stdev: 3.4 ms (5.3%)
Runs: 58 64 64 61 63 66 67 68 69 67
Warmup runs: 228		 Baseline
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4
Render issues:
- Initial updates: 1
Other Component 10 legacy scenario render Baseline
Mean: 66.7 ms
Stdev: 4.1 ms (6.1%)
Runs: 63 66 65 74 67 65 60 68 67 72
Warmup runs: 72		 Baseline
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4
Render issues:
- Initial updates: 1
Other Component 20 render Baseline
Mean: 68.4 ms
Stdev: 4.3 ms (6.2%)
Runs: 65 70 76 62 69 69 67 66 66 72 74 68 70 68 79 66 68 64 63 66
Warmup runs: 68		 Baseline
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4
Render issues:
- Initial updates: 1

Generated by 🚫 dangerJS against 65e1c52

@mdjastrzebski
refactor: use ts-markdown-builder
759a5e3 
refactor: prototype disclosure

refactor: replace rest of markdown methods

refactor: workarounds for markdown lib

chore: tweaks

chore: tweaks

chore: tweaks

chore: update markdown builder

chore: tweaks

chore: recreate yarn.lock

refactor: adapt markdown generation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mdjastrzebski