Do not explicitly import core library into plugins

Require that the developer import jcanvas before importing plugins (in the consuming application).
caleb531 · Jun 3, 2024 · 622e7a6 · 622e7a6
1 parent 2158b8d
commit 622e7a6
Show file tree

Hide file tree

Showing 5 changed files with 1 addition and 5 deletions.
diff --git a/rollup.config.mjs b/rollup.config.mjs
@@ -9,7 +9,7 @@ export default inputPaths.map((inputPath) => {
   const inputFilenameWithoutExtension = path.basename(inputPath, ".ts");
   return {
     input: [inputPath],
-    external: ["jquery", "jcanvas"],
+    external: ["jquery"],
     output: [
       {
         file: `dist/umd/${inputFilenameWithoutExtension}.min.js`,

diff --git a/src/jcanvas-crescents.ts b/src/jcanvas-crescents.ts
@@ -3,7 +3,6 @@
  * Copyright 2013-2024 Caleb Evans
  * Released under the MIT license
  */
-import "jcanvas";
 import $ from "jquery";
 
 // Cache some functions and constants

diff --git a/src/jcanvas-donuts.ts b/src/jcanvas-donuts.ts
@@ -3,7 +3,6 @@
  * Copyright 2013-2024 Caleb Evans
  * Released under the MIT license
  */
-import "jcanvas";
 import $ from "jquery";
 
 const PI = Math.PI;

diff --git a/src/jcanvas-handles.ts b/src/jcanvas-handles.ts
@@ -3,7 +3,6 @@
  * Copyright 2015-2024 Caleb Evans
  * Released under the MIT license
  */
-import "jcanvas";
 import $ from "jquery";
 
 interface JCanvasLayerWithHandles extends JCanvasLayer {

diff --git a/src/jcanvas-hearts.ts b/src/jcanvas-hearts.ts
@@ -3,7 +3,6 @@
  * Copyright 2013-2024 Caleb Evans
  * Released under the MIT license
  */
-import "jcanvas";
 import $ from "jquery";
 
 const PI = Math.PI;