Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor/code polish #21

Draft
wants to merge 24 commits into
base: main
Choose a base branch
from
Draft

refactor/code polish #21

wants to merge 24 commits into from

Conversation

christophertorres1
Copy link
Collaborator

@christophertorres1 christophertorres1 commented Jan 16, 2025

What's new in this PR

Description

Refactor

  • Changed all default exports to named exports for easier symbol renaming.
  • Renamed variables and files for clarity, reflecting the latest state of the project.
  • Replaced all functions with arrow functions for consistency.
  • Migrated to 'trees' and 'tree_species' Supabase tables with updated schemas, improving readability, removing unused columns, and accomodating for future shrub-related tables.
  • Updated Supabase database functions and queries to work with the new tables.
  • Removed unused CSS styles and style classes. Ordered style classes as they appear in their corresponding .tsx files.
  • Updated all spacing values (gap, padding, margin) to their nearest values in this spacing system for consistency.
  • Adjusted typography font size, line heights, and letter spacing based on Google Fonts' type scale generator for DM Sans.
  • Removed usused typography styles for simplicity.
  • Updated some components and screens to match the lastest designs on Figma.

Feature

  • Created functional checkboxes.
  • Added filter modal to the TreeSpeciesSearch screen.
  • Added links to Directory emails and phone numbers.

Screenshots

How to review

npx expo start -i

Next steps

I'm currently attempting to deploy a build based on this branch to TestFlight, but I'm facing the app crashing immediately on startup. EAS queues are hours long, so I'm running eas build --local --platform ios --clear-cache --profile preview for local testing on my connected device through Xcode. The iOS crash logs on my device do not clearly show what the issue is. However, because the app runs perfectly fine on the iOS simulator, the crashing threads reference turbomodules, and the app does not even show a screen before crashing, I believe the problem has something to do with installed modules or the translation to native code.

Relevant links

Online sources

Related PRs

CC: @christophertorres1

@christophertorres1 christophertorres1 marked this pull request as draft January 16, 2025 04:05
@christophertorres1 christophertorres1 changed the title Refactor/code polish refactor/code polish Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant