-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor/code polish #21
Draft
christophertorres1
wants to merge
24
commits into
main
Choose a base branch
from
refactor/code-polish
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new in this PR
Description
Refactor
Feature
Screenshots
How to review
npx expo start -i
Next steps
I'm currently attempting to deploy a build based on this branch to TestFlight, but I'm facing the app crashing immediately on startup. EAS queues are hours long, so I'm running
eas build --local --platform ios --clear-cache --profile preview
for local testing on my connected device through Xcode. The iOS crash logs on my device do not clearly show what the issue is. However, because the app runs perfectly fine on the iOS simulator, the crashing threads reference turbomodules, and the app does not even show a screen before crashing, I believe the problem has something to do with installed modules or the translation to native code.Relevant links
Online sources
Related PRs
CC: @christophertorres1