-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cases] updated claim filing flow #87
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made a few refactoring changes that should hopefully clean up the eligibility logic. If you test out the claim filing flow, you'll notice that filing a claim will cause a "claim status" bar to show up. As of now I just reused a previously created component. Do you think you could create a new one according to this figma design? Or perhaps refactor the CaseStatusBar
component so it can be used throughout the app? Let me know if this is doable or doesn't make sense.
I also didn’t refactor CaseStatusBar and made a new component instead b/c it would require changing the text styling (since it’s not the same as what’s pulled from getStatusColor). But whenever you review it and think it might be better I also have the code for it refactored instead where I override the styling. |
It's honestly probably fine to create a new component. Let's just run with this. |
What's new in this PR
Description
Screenshots
//: # 'Required for frontend changes, otherwise optional but strongly recommended. Add screenshots of expected behavior - GIFs if you're feeling fancy! Use the provided image template. Drag the desired image into the PR, then copy the link into the placeholder.'
How to review
Next steps
Relevant Links
Online sources
Related PRs
CC: @ronniebeggs