Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cases] updated claim filing flow #87

Merged
merged 18 commits into from
May 1, 2024

Conversation

arfamomin
Copy link
Contributor

@arfamomin arfamomin commented Apr 24, 2024

What's new in this PR

Description

  • new toggle between file a claim and opt out that switches potential flows for the user
  • once claim file indicated, new bar showing "claim filed" is added to top

Screenshots

//: # 'Required for frontend changes, otherwise optional but strongly recommended. Add screenshots of expected behavior - GIFs if you're feeling fancy! Use the provided image template. Drag the desired image into the PR, then copy the link into the placeholder.'

How to review

Next steps

Relevant Links

Online sources

Related PRs

CC: @ronniebeggs

Copy link

linear bot commented Apr 24, 2024

@ronniebeggs ronniebeggs marked this pull request as ready for review May 1, 2024 01:41
Copy link
Collaborator

@ronniebeggs ronniebeggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a few refactoring changes that should hopefully clean up the eligibility logic. If you test out the claim filing flow, you'll notice that filing a claim will cause a "claim status" bar to show up. As of now I just reused a previously created component. Do you think you could create a new one according to this figma design? Or perhaps refactor the CaseStatusBar component so it can be used throughout the app? Let me know if this is doable or doesn't make sense.

Screen Shot 2024-04-30 at 6 42 55 PM

@arfamomin
Copy link
Contributor Author

arfamomin commented May 1, 2024

for positioning the texts inside the bar, i used space-between in my commits but it looks a bit weird on my larger phone. here's what it looks with space-around but the look changed slightly so lmk if you want to change it.

@arfamomin
Copy link
Contributor Author

arfamomin commented May 1, 2024

I also didn’t refactor CaseStatusBar and made a new component instead b/c it would require changing the text styling (since it’s not the same as what’s pulled from getStatusColor). But whenever you review it and think it might be better I also have the code for it refactored instead where I override the styling.

@ronniebeggs
Copy link
Collaborator

I also didn’t refactor CaseStatusBar and made a new component instead b/c it would require changing the text styling (since it’s not the same as what’s pulled from getStatusColor). But whenever you review it and think it might be better I also have the code for it refactored instead where I override the styling.

It's honestly probably fine to create a new component. Let's just run with this.

@ronniebeggs
Copy link
Collaborator

for positioning the texts inside the bar, i used space-between in my commits but it looks a bit weird on my larger phone. here's what it looks with space-around but the look changed slightly so lmk if you want to change it.

I worry that it might not look great on every screen. Space around looks a little awkward on my screen so I think it's fine how it is for now.

@ronniebeggs ronniebeggs merged commit 8cee844 into main May 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants