Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[auth] refactor auth flow #85

Merged
merged 27 commits into from
May 1, 2024
Merged

[auth] refactor auth flow #85

merged 27 commits into from
May 1, 2024

Conversation

me-liu
Copy link
Contributor

@me-liu me-liu commented Apr 21, 2024

What's new in this PR

Description

  • created an AuthButton, and changed all buttons to that button
  • changed some of the wording to match the figma

Screenshots

  • lowkey it looks the same

How to review

Next steps

Relevant Links

Online sources

Related PRs

CC: @ronniebeggs

ronniebeggs
ronniebeggs requested changes Apr 21, 2024
View reviewed changes
Copy link
Collaborator

@ronniebeggs ronniebeggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far. A few simplifying changes should be applied across screens to make styling consistent.

src/app/(Authentication)/Welcome/index.tsx Outdated Show resolved Hide resolved
src/app/(Authentication)/OTPFlow/OTPVerify/index.tsx Outdated Show resolved Hide resolved
src/app/(Authentication)/OTPFlow/OTPVerify/index.tsx Outdated Show resolved Hide resolved
src/app/(Authentication)/OTPFlow/OTPVerify/index.tsx Outdated Show resolved Hide resolved
src/app/(Authentication)/SignUp/Address/index.tsx Outdated Show resolved Hide resolved
src/app/(Authentication)/SignUp/Address/index.tsx Outdated Show resolved Hide resolved
src/app/(Authentication)/Welcome/index.tsx Outdated Show resolved Hide resolved
src/app/(Authentication)/Welcome/styles.ts Outdated Show resolved Hide resolved
src/Components/AuthButton/AuthButton.tsx Outdated Show resolved Hide resolved
src/app/(Authentication)/Login/Email/index.tsx Outdated Show resolved Hide resolved
me-liu and others added 22 commits April 21, 2024 14:58
@me-liu
added buttons to auth flow, edited styling so less margins, edited au…
1d1b0e5 
…th input logic
@me-liu
changed sizes of buttons/inputs so it scales w screen size
2d91537
@ronniebeggs
[fix] welcome screen styling.
00e9c3e
@ronniebeggs
[fix] signup email input screen fixed.
a581540
@ronniebeggs
[feat] create styled components for reusable auth components.
1256cd3
@ronniebeggs
[wip] continue styling the signup flow email screen with styled compo…
1b76b27 
…nents.
@ronniebeggs
[feat] create styled components for all parts of the email input screen.
9109baa
@ronniebeggs
[feat] configure OTP input screen with styled components.
2615c24
@ronniebeggs
[feat] refactor auth input container to grow to its parent container'…
8d34f42 
…s width.
@ronniebeggs
[cleanup] remove unused imports and style.ts files.
3cda92e
@ronniebeggs
[feat] add styled component styling to login screens.
af4bafb
@ronniebeggs
[feat] refactor OTP screens with styled components.
1c55ad7
@ronniebeggs
[fix] resolve merge conflicts.
b57e3d0
@ronniebeggs
[refactor] move SafeArea to global styles.
0226994
@ronniebeggs
[refactor] apply global styles across screens.
2a6318c
@ronniebeggs
[fix] fix welcome screen styling.
c5cf32b
@ronniebeggs
[fix] mess around with profile screen button styling.
e685beb
@ronniebeggs
[refactor] refactor delete account screen with styled components.
9e5e916
@ronniebeggs
[fix] styling blah.
c77299e
@ronniebeggs
[refactor] moving stuff around.
9388b68
@ronniebeggs
[refactor] idk what I'm doing at this point.
8cf68f1
@ronniebeggs
[fix] more refactor cry
ec8678c
@ronniebeggs ronniebeggs changed the title Auth Flow Styling Bugs [auth] refactor auth flow Apr 24, 2024
stephaniewong2
stephaniewong2 reviewed Apr 25, 2024
View reviewed changes
Copy link
Collaborator

@stephaniewong2 stephaniewong2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove back button on forgot password flow

@ronniebeggs ronniebeggs merged commit 25a756a into main May 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephaniewong2 stephaniewong2 stephaniewong2 left review comments

@ronniebeggs ronniebeggs ronniebeggs requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@me-liu @ronniebeggs @stephaniewong2 @foloye