CSS: New type styles + docs #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cal-itp-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@machikoyasuda would you mind putting this in Draft until it is ready for review? |
|
@thekaveman Oops, sorry - did not mean to request a review earlier. Now it's ready for review. |
angela-tran
approved these changes
Jul 25, 2024
There was a problem hiding this comment.
This looks good to me 👍
I think it might be good to add /stylesheet.html to our robots.txt so that search engines don't index the page, but it's also probably not a big deal if it does get indexed. Thoughts @machikoyasuda ?
|
@angela-tran That's a great idea! I will do that in this PR. |
|
@angela-tran thank you for the suggestion: 8c2f92a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #368
These new styles will be used for both Partners and Customer Stories pages. I have added new code in CSS, but I have not changed any code or designs on the existing pages -- so this is a safe PR to merge b/c no user-facing changes are going into production.
What this PR does
How to test
🟢🟢 Once this PR is reviewed, this PR can be deployed to Production 🟢🟢