-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSS: New type styles + docs #371
Conversation
✅ Deploy Preview for cal-itp-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@machikoyasuda would you mind putting this in Draft until it is ready for review? |
@thekaveman Oops, sorry - did not mean to request a review earlier. Now it's ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me 👍
I think it might be good to add /stylesheet.html
to our robots.txt
so that search engines don't index the page, but it's also probably not a big deal if it does get indexed. Thoughts @machikoyasuda ?
@angela-tran That's a great idea! I will do that in this PR. |
@angela-tran thank you for the suggestion: 8c2f92a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
closes #368
These new styles will be used for both Partners and Customer Stories pages. I have added new code in CSS, but I have not changed any code or designs on the existing pages -- so this is a safe PR to merge b/c no user-facing changes are going into production.
What this PR does
How to test
🟢🟢 Once this PR is reviewed, this PR can be deployed to Production 🟢🟢