Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add piece-wise constant radial dependence of parameters to 2D DG discretization #337

Open
wants to merge 19 commits into
base: master
Choose a base branch
from

Conversation

jbreue16
Copy link
Contributor

@jbreue16 jbreue16 commented Dec 4, 2024

This PR adds piece-wise constant radial dependence of parameters to the 2D DG discretization.

TODO

  • change parameter sizes from radNPoints to radNElem
  • radially dependent porosity
  • radially dependent velocity
  • radially dependent particle type volume fraction
  • radially and component dependent axial dispersion
  • radially and component dependent radial dispersion
  • user-defined element-spacing to improve control over radial inhomogeneity and refinement
  • column length parameter sensitivity (radius wont be fixed?) -> see aux equations todo in residualImpl
  • Move axial and radial dispersion to main equation and allow sensitivities
  • Add Jacobian test with radially variable parameters
  • arbitrary polynomial degree per radial element?
  • Jacobian test with radially variable partypeVolFrac

Remenants from #160 :

  • consistent initialization with AD Jacobian and req binding fails
  • FD Jacobian pattern comparison fails
  • Add documentation (unify the modelling documentation of GRM2D and LRMP2D)
  • radial coordinate was > column_radius by some 1e-18 .. which was also written to the output, triggering an exception in the evaluation.. should there be something different on the c+ side?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

1 participant