-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add aggregation and breakage to crystallization module #241
base: master
Are you sure you want to change the base?
Conversation
Things to consider when modularizing the current code @jbreue16 :
Possible combinations are:
Only 1, 2, and 4 don't have the two additional components. |
1b1e733
to
7412f7d
Compare
7412f7d
to
c4cb521
Compare
dedd7d3
to
d8a0c43
Compare
@WFlynnZ I found that the Jacobian tests fail, if we set the |
@jbreue16 I remember we troubleshooted this a while ago, if I recall correctly, there was an issue with the CSTR module, which was fixed? I checked the PBM Jacobians a number of times now,,, it should be hard to find more mistakes in these higher order schemes, maybe this is related to the tolerances? Some entries need large tolerances because the absolute values are big. |
d9c87ab
to
2d68ec0
Compare
There are multiple branches with parts of the functionality that we want, i.e. sole aggregation, sole breakage, sole PBM and all of them combined. However, the code is not modular.
The respective branches are on @WFlynnZ fork of CADET.
We need to figure out a neat modularization and then incorporate the code from the aforementioned branches, which we will do on this branch here.
Todo:
_bin
loopPBMKernel
ReconstructionParams
andJacobianParams
, which have too many/unused fields depending on which reconstruction is used)