-
Notifications
You must be signed in to change notification settings - Fork 801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve cross cluster components shutdown logic #4662
Improve cross cluster components shutdown logic #4662
Conversation
Pull Request Test Coverage Report for Build f4863a24-7d93-4925-8cb1-90f21d64c936
💛 - Coveralls |
if p.ctx.Err() != nil { | ||
return | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would this be better above, in the loop? or is that unsafe to interrupt? (though if anything under it checks the context, it may still be interrupted)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. I don't have a strong opinion on this. Moving it into the for loop also works and probably can save us some iterations during the shutdown.
I was thinking the for loop is already non-blocking once the context is cancelled on shutdown, and we just need one check before sending the response back instead of checking it in each iteration.
I don't follow the set of changes as a whole, but reducing |
What changed?
Why?
How did you test it?
Potential risks
Release notes
Documentation Changes