Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing proto to thrift enum mappings and unit tests for EnumMapper #924

Merged
merged 1 commit into from
Oct 23, 2024

Commits on Oct 23, 2024

  1. Add missing proto to thrift enum mappings and unit tests for both Enu…

    …mMappers
    
    Add a suite of tests that will automatically fail if new enum types are added in IDL but the mappers aren't updated. This was done in a few ways:
    - For enums that have mappers both directions, we roundtrip all thrift values and assert that they're equal.
    - For enums that are identical across thrift/proto, we generate a mapping based on the value names and assert that the mapper matches it.
    - For enums that aren't identical, we explicitly assert that our mapping contains all values.
    natemort committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    58b9bc5 View commit details
    Browse the repository at this point in the history