Remove unused code from cadence.internal package #921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natemort
requested review from
Groxx,
abhishekj720,
shijiesheng,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
Pull Request Test Coverage Report for Build 2542Details
💛 - Coveralls |
3vilhamster
approved these changes
Oct 22, 2024
3vilhamster
reviewed
Oct 22, 2024
3vilhamster
reviewed
Oct 22, 2024
| @@ -621,26 +437,6 @@ public static GetWorkflowExecutionHistoryResponse getHistoryPage( | |||
| return history; | |||
| } | |||
|
|
|||
| /** Returns workflow instance history in a human readable format. */ | |||
| public static String prettyPrintHistory( | |||
There was a problem hiding this comment.
This could be useful; I wonder why have you decided to drop this.
There was a problem hiding this comment.
I think it's potentially useful but it's long unused and untested. If we need similar functionality we can rewrite it.
3vilhamster
reviewed
Oct 22, 2024
| * @param <R> activity return type | ||
| * @return activity result | ||
| */ | ||
| public static <R> R executeActivity( |
There was a problem hiding this comment.
I'm not really sure why this exists, it's long unused and untested. I think it's best we just remove it.
Shaddoll
approved these changes
Oct 22, 2024
natemort
force-pushed
the
deadcode
branch
2 times, most recently
from
d895c5f
to
3fdf3d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Remove unused code from internal packages to improve code coverage and reduce maintenance burden. Users shouldn't be accessing internals.
Why?
Improving code coverage and reducing maintenance burden
How did you test it?
Unit tests
Potential risks
User code may be accessing internals within the client and could break. Generally this should be a compile time breakage and we do not support accessing internals.
Release notes
Documentation Changes