Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix registry loading when custom registries present #4553

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

rfresh2
Copy link
Contributor

@rfresh2 rfresh2 commented Nov 9, 2024

Resolves mod compat issues including #4526

Should be forward merged up through 1.21 as same issue is present there

@leijurv leijurv merged commit 1bfc030 into cabaletta:1.20.5 Nov 21, 2024
3 of 4 checks passed
@ZacSharp
Copy link
Collaborator

ZacSharp commented Dec 7, 2024

Do you perhaps know how to port this to 1.21.3/1.21.4?
Though it seems like pack loading is broken on 1.21 (EDIT: meant 1.21.3/4) anyway (tested 1.21.3 with tweaker:runClient, 1.21.3 with fabric:runClient, 1.21.4 with tweaker:runClient, 1.21.4 with neoforge 21.4.10-beta)

@rfresh2
Copy link
Contributor Author

rfresh2 commented Dec 8, 2024

@rfresh2
Copy link
Contributor Author

rfresh2 commented Dec 8, 2024

you can cherry pick and throw in your merge PR's to 1.21.1 + 1.21.3

and then i can rebase 1.21.4 pr on top

@rfresh2
Copy link
Contributor Author

rfresh2 commented Dec 8, 2024

and then i can rebase 1.21.4 pr on top

nvm leijurv merged 1.21.4 already

This was referenced Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants