Interpolated Looking implementation #4505
Open
+257
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced old, in many cases not working "smoothlook" with "interpolatedLook", which forces global player rotation in both axis to follow a "path" from source looking position(rotation) to target, removing jittering when, for instance, mining blocks; it WILL hinder baritone's default mining speed, but the main purpose is to make actions seem slightly more humanly possible, time of the interpolation is controlled by interpolatedLookLength, in ticks.
8mb.video-4EL-9Jlk4hg4.mp4"showcase" video |
| @@ -120,4 +121,8 @@ public static double entityDistanceToCenter(Entity entity, BlockPos pos) { | |||
| public static double entityFlatDistanceToCenter(Entity entity, BlockPos pos) { | |||
| return distanceToCenter(pos, entity.position().x, pos.getY() + 0.5, entity.position().z); | |||
| } | |||
|
|
|||
| public static Vec3 vDivide (Vec3 A, Vec3 B) { | |||
There was a problem hiding this comment.
use google codestyle guidelines plz
| if (this.target.mode == Target.Mode.SERVER) { | ||
| ctx.player().setYRot(this.prevRotation.getYaw()); | ||
| ctx.player().setXRot(this.prevRotation.getPitch()); | ||
| }// else if (ctx.player().isFallFlying() && Baritone.settings().elytraSmoothLook.value) { |
There was a problem hiding this comment.
what is it? 💀. Commits the commented code is pretty bullshit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced old, in many cases not working "smoothlook" with "interpolatedLook", which forces global player rotation in both axis to follow a "path" from source looking position(rotation) to target, removing jittering when, for instance, mining blocks; it WILL hinder baritone's default mining speed, but the main purpose is to make actions seem slightly more humanly possible, time of the interpolation is controlled by interpolatedLookLength, in ticks.