Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support both upper and lower case E in scientific notation #135

Merged
merged 3 commits into from
Feb 25, 2024

Conversation

matt-oliver-canada
Copy link
Contributor

@matt-oliver-canada matt-oliver-canada commented Feb 23, 2024

Brief

add support for upper case E in scientific notation values.

Checklist

  • Add relevant labels to the Pull Request
  • Review test results and code coverage
    • Review snapshot test results for deviations
  • Review code changes
    • Create relevant test scenarios
    • Update examples
    • Update JSON schema
  • Update documentation
    • Update examples in README
  • Update changelog
  • Update version number

Resolves

Resolves #134

Evidence

  • Analyze how the change might impact existing code
    Tests added to pytest validate it's backward compatible.

  • Provide evidence that the feature is tested and covered properly
    I made this new change to the local venv in my system.

@matt-oliver-canada matt-oliver-canada changed the title Both case e Support both upper and lower case E in scientific notation Feb 23, 2024
@matt-oliver-canada matt-oliver-canada marked this pull request as ready for review February 23, 2024 01:09
Copy link

codecov bot commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.31%. Comparing base (2ec017f) to head (ea885cd).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #135   +/-   ##
=======================================
  Coverage   96.31%   96.31%           
=======================================
  Files          13       13           
  Lines        1465     1465           
=======================================
  Hits         1411     1411           
  Misses         54       54           
Flag Coverage Δ
3.10 96.31% <ø> (ø)
3.11 96.31% <ø> (ø)
3.12 96.31% <ø> (ø)
3.6 96.31% <ø> (?)
3.7 96.31% <ø> (?)
3.8 96.31% <ø> (?)
3.9 96.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@c4deszes c4deszes self-requested a review February 25, 2024 19:42
@c4deszes c4deszes merged commit 8a38dc2 into c4deszes:master Feb 25, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support upper and lower case E for scientific notiation
2 participants