Consolidation + removing dev GenPipes as GenPipes 5 is a package #17
Conversation
| apptainer-version: 1.3.4 | ||
| - name: Create sif image | ||
| run: apptainer build -F container/wrapper_genpipes/images/genpipes-${{ env.TAG_NAME }}.sif docker://${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}:${{ env.TAG_NAME }} | ||
| - name: Comit and Push sif image |
There was a problem hiding this comment.
The sif should be publish in a release, not pushed to the repo. That would make it way too big and also make it reach its size limit.
Dockerfile
Outdated
There was a problem hiding this comment.
You should try to run the apt install and updatd in as few RUN call a possible and also make sur to purge the cache and deleted tmp files on the same RUN line. This will make the container image thiner.
You can probably run all the apt and wget on the same line acctually
README.md
Outdated
|
|
||
| Follow installation procedure from the [Singularity install page](https://github.com/hpcng/singularity/blob/master/INSTALL.md) or the [Docker install page](https://docs.docker.com/get-docker/). |
There was a problem hiding this comment.
We should point to apptainer directly and let singularity stay there for compatibility but talk about apptainer in the doc.
https://apptainer.org/docs/user/main/quick_start.html
or https://github.com/apptainer/apptainer/blob/main/INSTALL.md
for install link
There was a problem hiding this comment.
The sif file should be uploaded as a release tgz file
https://github.com/marketplace/actions/upload-files-to-a-github-release
The action crated the sif (will done here), then puts it in the place that looks like this:
./wrapper_genpipes
./wrapper_genpipes/bin
./wrapper_genpipes/bin/container_wrapper.sh
./wrapper_genpipes/images
./wrapper_genpipes/images/genpipes_v<release_number>.sif
./wrapper_genpipes/images/genpipes.sif <symlink to genpipes_v<release_number>.sif >
./wrapper_genpipes/etc
./wrapper_genpipes/etc/wrapper.conf.tpl
run tar -zcvf wrapper_genpipes.tgz wrapper_genpipes
upload wrapper_genpipes.tgz to release.
No description provided.