Frontend reduce warnings #871
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nafiz1001
force-pushed
the
frontend-reduce-warnings
branch
3 times, most recently
from
8ee707f
to
bcee39c
Compare
nafiz1001
force-pushed
the
frontend-reduce-warnings
branch
from
bcee39c
to
06a919b
Compare
nafiz1001
force-pushed
the
frontend-reduce-warnings
branch
from
0b08615
to
fbaceaa
Compare
nafiz1001
force-pushed
the
frontend-reduce-warnings
branch
from
fbaceaa
to
1870c46
Compare
nafiz1001
force-pushed
the
frontend-reduce-warnings
branch
from
bb5ed8a
to
6906942
Compare
|
I think that's enough for now. There are still a few more small issues, but I don't want to go too deep into rabbit holes. |
|
these improvements are nice, there might be a few things where i would maybe have an opinion on but overall, it looks good. good in my book |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.