Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bookmark page has no end point which renders users experience #6 Fixed #111

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Hemu21
Copy link

@Hemu21 Hemu21 commented Feb 26, 2024

Bookmarks are showing in navigation but not redirecting to bookmarks page.

Description

I added the new folder for bookmarks page why because I check the project folder. I doesn't found any file related to bookmarks page and I added the endpoint to routers file and I created the test for it. I make it that User saved Bookmarks are visible in that Bookmarks page.

Steps to reproduce

  • Set-up localhost and run it
  • Now login to account and go to home page
  • click on the bookmarks in left side navigation.
  • you will get 404 page error or You can't find anything.

Issue Link

https://github.com/c2siorg/Codelabz/issues/6

Related Issue

Bookmark page has no end point which renders users experience resolve #6

How Has This Been Tested?

  • Set-up localhost and run it
  • Now login to account and go to home page
  • click on the bookmarks in left side navigation.
  • User have to redirect to bookmarks page as shown below.

Screenshots or GIF (In case of UI changes):

bookmarks_redirect_issue_fix

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Review Request

@ABHISHEK-PANDEY2 @Maahi10001 @Shiva-Nanda @c2sibot Please Review My PR and Approve it.

@rohitPandey469
Copy link

@Hemu21 brother this is solved too scorelab/Codelabz#1168 but if you're doing it in more optimized way then do not close it, you can check for implementation method in changed files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bookmark page has no end point which renders users experience
2 participants