simon/move to picos #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it's a dep of picos anyway
we factor most of the thread workers' logic in `Worker_loop_`, which is now shared between Ws_pool and Fifo_pool
c-cube
force-pushed
the
simon/move-to-picos
branch
from
10fd733
to
a36342d
Compare
it should be deterministic now!
wintersteiger
approved these changes
Aug 29, 2024
src/core/runner.mli
Outdated
| @@ -33,14 +34,14 @@ val shutdown_without_waiting : t -> unit | |||
|
|
|||
| exception Shutdown | |||
|
|
|||
| val run_async : ?ls:Task_local_storage.t -> t -> task -> unit | |||
| val run_async : ?fiber:fiber -> t -> task -> unit | |||
| (** [run_async pool f] schedules [f] for later execution on the runner | |||
| in one of the threads. [f()] will run on one of the runner's | |||
| worker threads/domains. | |||
| @param ls if provided, run the task with this initial local storage | |||
There was a problem hiding this comment.
Docstring comment for ?fiber missing here and in the following functions.
c-cube
force-pushed
the
simon/move-to-picos
branch
from
fd11e1c
to
7df8c06
Compare
use the inheritable keys
based on picos_sync
c-cube
added a commit
to c-cube/opam-repository
that referenced
this pull request
Sep 10, 2024
CHANGES: - add `Moonpool_fiber.spawn_top_ignore` - add `moonpool-io`, based on `picos_io` (still very experimental) - move to picos as the foundation layer for concurrency primitives (c-cube/moonpool#30) - move to `thread-local-storage` 0.2 with get/set API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
move to picos as the foundational concurrency abstraction