Fix Spock hand icon button #32
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch updates the font awesome class to fix the display of the Spock hand icon in the cataloging toolbar example. It also adds the button role and tabindex for better accessibility. To test: 1. Go to the details page of a bibliographic record 2. Notice the live long and prosper button is missing the Spock hand icon and is not tabbable 3. Apply patch and restart_all 4. Confirm the Spock hand displays correctly and the button is now tabbable Peace and long life.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch updates the font awesome class to fix the display of the Spock hand icon in the cataloging toolbar example. It also adds the button role and tabindex for better accessibility.
To test:
Peace and long life.