fix player destroy control plugins memeory leak

bytedance · Oct 10, 2024 · 8ef44a4 · 8ef44a4
1 parent bfbfcab
commit 8ef44a4
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/packages/xgplayer/src/mediaProxy.js b/packages/xgplayer/src/mediaProxy.js
@@ -376,7 +376,7 @@ class MediaProxy extends EventEmitter {
       let _e = this.media.error || error
       const type = _e.code ? ERROR_TYPE_MAP[_e.code] : 'other'
       let message = _e.message
-      if (!this.media.currentSrc) {
+      if (!(this.media.currentSrc || this.media.srcObject)) {
         message = 'empty_src'
         _e = {
           code: 6,

diff --git a/packages/xgplayer/src/plugins/controls/index.js b/packages/xgplayer/src/plugins/controls/index.js
@@ -174,6 +174,10 @@ class Controls extends Plugin {
       this.unbind('mouseenter', this.onMouseEnter)
       this.unbind('mouseleave', this.onMouseLeave)
     }
+    this.left = null
+    this.center = null
+    this.right = null
+    this.innerRoot = null
   }
 
   render () {