Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISLE: update language reference #9517

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Kmeakin
Copy link
Contributor

@Kmeakin Kmeakin commented Oct 29, 2024

The language specified in language-reference.md and the language recognised by parser.rs had drifted out of sync. Update the language reference to match the actual language more closely.

@Kmeakin Kmeakin requested a review from a team as a code owner October 29, 2024 13:10
@Kmeakin Kmeakin requested review from cfallin and removed request for a team October 29, 2024 13:10
@github-actions github-actions bot added cranelift Issues related to the Cranelift code generator isle Related to the ISLE domain-specific language labels Oct 29, 2024
Copy link

Subscribe to Label Action

cc @cfallin, @fitzgen

This issue or pull request has been labeled: "cranelift", "isle"

Thus the following users have been cc'd because of the following labels:

  • cfallin: isle
  • fitzgen: isle

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

Copy link
Member

@cfallin cfallin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Generally I'm fine with extending the grammar to cover the new stuff; cc @avanhatt for thoughts on documenting this and if/how we want to add more info as well (or perhaps a pointer to the project/paper at least?).

cranelift/isle/docs/language-reference.md Outdated Show resolved Hide resolved
cranelift/isle/docs/language-reference.md Show resolved Hide resolved
@Kmeakin Kmeakin force-pushed the km/isle/language-reference branch 3 times, most recently from b9a5da6 to b942aea Compare October 30, 2024 14:49
Copy link
Member

@cfallin cfallin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates LGTM; final signoff from @avanhatt or @mmcloughlin would be great to verify this (thanks!).

The language specified in `language-reference.md` and the language
recognised by `parser.rs` had drifted out of sync. Update the language
reference to match the actual language more closely.

Copyright (c) 2024, Arm Limited.

Signed-off-by: Karl Meakin <[email protected]>
Copy link
Member

@avanhatt avanhatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, too, thanks for updating this doc!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cranelift Issues related to the Cranelift code generator isle Related to the ISLE domain-specific language
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants