-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ISLE: update language reference #9517
base: main
Are you sure you want to change the base?
Conversation
Subscribe to Label Action
This issue or pull request has been labeled: "cranelift", "isle"
Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Generally I'm fine with extending the grammar to cover the new stuff; cc @avanhatt for thoughts on documenting this and if/how we want to add more info as well (or perhaps a pointer to the project/paper at least?).
b9a5da6
to
b942aea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updates LGTM; final signoff from @avanhatt or @mmcloughlin would be great to verify this (thanks!).
b942aea
to
0ef9953
Compare
The language specified in `language-reference.md` and the language recognised by `parser.rs` had drifted out of sync. Update the language reference to match the actual language more closely. Copyright (c) 2024, Arm Limited. Signed-off-by: Karl Meakin <[email protected]>
0ef9953
to
7458145
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, too, thanks for updating this doc!
The language specified in
language-reference.md
and the language recognised byparser.rs
had drifted out of sync. Update the language reference to match the actual language more closely.