Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding an --emit-opt-clif CLI option #9150

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dimitris-aspetakis
Copy link

@dimitris-aspetakis dimitris-aspetakis commented Aug 20, 2024

The option --emit-opt-clif follows the --emit-clif implementation from wasmtime's CLI, but the output comes with the egraph optimizations applied. It has been helpful for work on #6260. From discussions in zulip, it seemed more generally desirable.

  • I consider some small changes in crates/cranelift/src/compiler.rs to be a bit "hacky", probably due to my inexperience with the borrow checker...
  • Maybe there are some CLI error messages you would like introduced (e.g. if the paths for --emit-clif and --emit-opt-clif are the same) — I haven't created any since I'm not even sure about the CLI interface you would prefer.
  • The current state does not include support for the wasmtime explorer.

@dimitris-aspetakis dimitris-aspetakis requested a review from a team as a code owner August 20, 2024 06:13
@dimitris-aspetakis dimitris-aspetakis requested review from elliottt and removed request for a team August 20, 2024 06:13
The option --emit-opt-clif follows the --emit-clif implementation, but
the output comes with the egraph optimizations applied.

* This commit does not include support for the wasmtime explorer.
@github-actions github-actions bot added wasmtime:api Related to the API of the `wasmtime` crate itself wasmtime:config Issues related to the configuration of Wasmtime labels Aug 20, 2024
Copy link

Label Messager: wasmtime:config

It looks like you are changing Wasmtime's configuration options. Make sure to
complete this check list:

  • If you added a new Config method, you wrote extensive documentation for
    it.

    Our documentation should be of the following form:

    Short, simple summary sentence.
    
    More details. These details can be multiple paragraphs. There should be
    information about not just the method, but its parameters and results as
    well.
    
    Is this method fallible? If so, when can it return an error?
    
    Can this method panic? If so, when does it panic?
    
    # Example
    
    Optional example here.
    
  • If you added a new Config method, or modified an existing one, you
    ensured that this configuration is exercised by the fuzz targets.

    For example, if you expose a new strategy for allocating the next instance
    slot inside the pooling allocator, you should ensure that at least one of our
    fuzz targets exercises that new strategy.

    Often, all that is required of you is to ensure that there is a knob for this
    configuration option in wasmtime_fuzzing::Config (or one
    of its nested structs).

    Rarely, this may require authoring a new fuzz target to specifically test this
    configuration. See our docs on fuzzing for more details.

  • If you are enabling a configuration option by default, make sure that it
    has been fuzzed for at least two weeks before turning it on by default.


To modify this label's message, edit the .github/label-messager/wasmtime-config.md file.

To add new label messages or remove existing label messages, edit the
.github/label-messager.json configuration file.

Learn more.

Copy link
Member

@alexcrichton alexcrichton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! As a possible alternative though, what do you think about not adding a new option but redefining --emit-clif as this option instead? That way optimized clif would be emitted by deafult and non-optimized clif could be emitted with -C opt-level=0

@elliottt elliottt removed their request for review October 24, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wasmtime:api Related to the API of the `wasmtime` crate itself wasmtime:config Issues related to the configuration of Wasmtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants