Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a fuzz target for exercising bounds checks with various memory configs #8742

Merged
merged 1 commit into from
Jun 6, 2024
Merged

Add a fuzz target for exercising bounds checks with various memory configs #8742

merged 1 commit into from
Jun 6, 2024

Conversation

fitzgen
Copy link
Member

@fitzgen fitzgen commented Jun 4, 2024

No description provided.

@fitzgen fitzgen requested a review from alexcrichton June 4, 2024 19:31
@fitzgen fitzgen requested a review from a team as a code owner June 4, 2024 19:31
alexcrichton
alexcrichton reviewed Jun 4, 2024
View reviewed changes
Copy link
Member

@alexcrichton alexcrichton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Any particular motivation for this or just curious to see how it fares?

crates/fuzzing/src/oracles/memory.rs Show resolved Hide resolved
crates/fuzzing/src/generators/memory.rs Outdated Show resolved Hide resolved
crates/fuzzing/src/generators/memory.rs Outdated Show resolved Hide resolved
@github-actions github-actions bot added the fuzzing Issues related to our fuzzing infrastructure label Jun 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 4, 2024

Subscribe to Label Action

cc @fitzgen

This issue or pull request has been labeled: "fuzzing"

Thus the following users have been cc'd because of the following labels:

  • fitzgen: fuzzing

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

@fitzgen
Copy link
Member Author

fitzgen commented Jun 5, 2024

Any particular motivation for this or just curious to see how it fares?

I started writing this for my implementation of the custom-page-sizes proposal, but figured I'd split it out and land it first to keep PRs small.

@fitzgen fitzgen requested a review from a team as a code owner June 5, 2024 17:48
@fitzgen fitzgen requested review from cfallin and removed request for a team June 5, 2024 17:48
cfallin
cfallin approved these changes Jun 5, 2024
View reviewed changes
crates/fuzzing/src/oracles/memory.rs Outdated Show resolved Hide resolved
@github-actions github-actions bot added cranelift Issues related to the Cranelift code generator cranelift:area:machinst Issues related to instruction selection and the new MachInst backend. labels Jun 5, 2024
@fitzgen fitzgen enabled auto-merge June 6, 2024 13:38
@fitzgen fitzgen added this pull request to the merge queue Jun 6, 2024
Merged via the queue into bytecodealliance:main with commit 7a37e31 Jun 6, 2024
36 checks passed
@fitzgen fitzgen deleted the fuzz-bounds-checks branch June 6, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcrichton alexcrichton alexcrichton left review comments

@cfallin cfallin cfallin approved these changes

Assignees
No one assigned
Labels
cranelift:area:machinst Issues related to instruction selection and the new MachInst backend. cranelift Issues related to the Cranelift code generator fuzzing Issues related to our fuzzing infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fitzgen @alexcrichton @cfallin