Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic support for DWARF processing with components #8693

Merged
merged 1 commit into from
Jun 5, 2024

Commits on Jun 5, 2024

  1. Add basic support for DWARF processing with components

    This commit updates the native-DWARF processing (the `-D debug-info` CLI
    flag) to support components. Previously component support was not
    implemented and if there was more than one core wasm module within a
    component then dwarf would be ignored entirely.
    
    This commit contains a number of refactorings to plumb a more full
    compilation context throughout the dwarf processing pipeline. Previously
    the data structures used only were able to support a single module. A
    new `Compilation` structure is used to represent the results of an
    entire compilation and is plumbed through the various locations. Most of
    the refactorings in this commit were then to extend loops to loop over
    more things and handle the case where there is more than one core wasm
    module.
    
    I'll admit I'm not expert on DWARF but basic examples appear to work
    locally and most of the additions here seemed relatively straightforward
    in terms of "add another loop to iterate over more things" but I'm not
    100% sure how well this will work. In theory this now supports
    concatenating DWARF sections across multiple core wasm modules, but
    that's not super well tested.
    alexcrichton committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    4da0b2c View commit details
    Browse the repository at this point in the history