feat(rumqttc): allow empty client id #791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arunanshub
force-pushed
the
feat/allow-zero-empty-client-id
branch
3 times, most recently
from
7d8218b
to
bee99c5
Compare
…ient_id` We now provide an additional function, `try_set_clean_session` that returns error if `client_id` is a 0 byte string and `clean_session` is not `true`.
arunanshub
force-pushed
the
feat/allow-zero-empty-client-id
branch
from
bee99c5
to
7237d55
Compare
swanandx
requested changes
Feb 2, 2024
swanandx
reviewed
Feb 2, 2024
swanandx
requested changes
Feb 3, 2024
Co-authored-by: Swanand Mulay <[email protected]>
|
Hey @arunanshub , any updates!? |
|
Working on it. Upon referencing Mosquitto lib, it has been difficult to
find where they are validating the "clean_start", "client_id" and save
session options. It seems that a single codebase provides support for v3
and v5. v5 is enabled by flag `CLIENT_RR` (MQTT v5 request response), and
they are using a lot of conditional compilation. Will keep you updated.
…On Thu, 8 Feb, 2024, 10:07 Swanand Mulay, ***@***.***> wrote:
Hey @arunanshub <https://github.com/arunanshub> , any updates!?
—
Reply to this email directly, view it on GitHub
<#791 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALRQYQ24CMX7VUAIJTFH32DYSRJBJAVCNFSM6AAAAABCWEUCCSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZTGM2TCNRRG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
as discussed already, they ( or other clients ) don't validate it! This PR is blocked by adding tests to check if are using assert correctly and other changes suggested in review. Can you please prioritise em so we can close the PR? Then you can continue your research and open follow up PR ( if required ) 😁 wdyt? your call, otherwise if you prefer, lmk when we are good to go for this PR 👍 |
swanandx
approved these changes
Feb 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #667
Type of change
Checklist:
cargo fmtCHANGELOG.mdif it's relevant to the users of the library. If it's not relevant mention why.