This repository has been archived by the owner on Oct 17, 2022. It is now read-only.
* Parse positionally independent WWW-Authentication header #26
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the time, the
WWW-Authentication
header comes back looking like this:The original code handled this fine. However, sometimes the header can come back in the following form:
When this happens, the program would throw an error during parsing:
Error parsing internal domain name using OWA. This usually means OWA is being hosted on-prem or the target has a hybrid AD deployment
.This pull aims to reduce these false negatives by parsing until reaching the
NTLM
section of the header.