Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added script to download the crawl #12

Merged
merged 2 commits into from
Mar 8, 2018

Conversation

innovationchef
Copy link
Member

This PR is in reference to #1
@justinccdev , as you suggested, I added a separate script for dumping and I am attaching a sample output of the dump. Please let me know if it has got issues.
crawl.txt

Copy link
Member

@justinccdev justinccdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @innovationchef

  • urls_to_exclude() is unused
  • there are unused imports
  • I'd like to see filepath as an input parameter, though a default would be fine. If so, it should cut off the extension with generic code, e.g. with os.path.splitext(), not assume a suffix of '.db'
  • The params in the documentation of save_crawl_data() do not match the actual parameter names. I'm not sure you need a separate function of this yet, it's a pretty simple piece of code.
  • Opening the file handle for every single write is not desirable. It needs to be opened just once.
  • Do you use an IDE? If so, I can recommend the free pycharm as this is good at picking up on some of these issues.

@innovationchef
Copy link
Member Author

Hey @justinccdev ,
I incorporated the changes. Please have a look.
Yes, I have been using Sublime till now. I shifted to pycharm and it is really helpful while working on a large code base .
Thanks for the suggestions :)

@justinccdev
Copy link
Member

Thanks @innovationchef

@justinccdev justinccdev closed this Mar 8, 2018
@justinccdev justinccdev reopened this Mar 8, 2018
@justinccdev justinccdev merged commit deae4d7 into buzzbangorg:master Mar 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants