fetch_server: support digest function and blake3 #6382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sluongng
force-pushed
the
sluongng/fetch-server-blake3
branch
from
940ab9f
to
93c847f
Compare
bduffany
requested changes
Apr 17, 2024
bduffany
approved these changes
Apr 22, 2024
| SizeBytes: 1, | ||
| } | ||
| cacheRN := digest.NewResourceName(blobDigest, instanceName, rspb.CacheType_CAS, checksumFunc) | ||
| log.CtxInfof(ctx, "Looking up %s in cache", blobDigest.Hash) |
There was a problem hiding this comment.
wdyt about removing these log.Info lines in the non-error cases? I think they might be a tad excessive
There was a problem hiding this comment.
Good suggestion.
I will switch these to Debug level instead of removing them.
These could be fairly useful for development purposes.
Implement support for digest function in FetchBlobRequest as well as usage of Blake3 as a digest func.
Co-authored-by: Brandon Duffany <[email protected]>
Switch happy path log to Debug
sluongng
force-pushed
the
sluongng/fetch-server-blake3
branch
from
aff4135
to
55556ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement support for digest function in FetchBlobRequest as well as
usage of Blake3 as a digest func.