Add linux-arm64 release binaries #5960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bduffany
force-pushed
the
executor-arm-release
branch
7 times, most recently
from
9a50ccf
to
84599df
Compare
bduffany
force-pushed
the
executor-arm-release
branch
from
84599df
to
449fd62
Compare
maggie-lou
approved these changes
Feb 21, 2024
tylerwilliams
approved these changes
Feb 21, 2024
|
you want to file a bug on that repo (from the email) letting them know the installed packages are not the same? |
|
Also thanks for doing this! will be nice to have :) |
I think this is what they meant by "The image does not have any pre-installed tools" in the original email |
|
(Waiting to submit this until I have time to do a test build with the arm64 binaries.) |
bduffany
force-pushed
the
executor-arm-release
branch
9 times, most recently
from
3f940c8
to
cbe8915
Compare
bduffany
force-pushed
the
executor-arm-release
branch
from
cbe8915
to
9aace78
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test build (tested everything except the
gh release uploadcommand): https://github.com/buildbuddy-io/buildbuddy/actions/runs/7993652037/job/21829927623?pr=5960.I ran
which ghto sanity check thatghwas installed. Looks like it is not yet installed by default on the arm64 runners, so I added an installation step for that.We probably also should add docker image builds - can do that in a separate PR.
Related issues: N/A