sluongng/reapply linkopt macos #5698
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sluongng
commented
Jan 11, 2024
sluongng
commented
- Revert "macos: rollback linkopt flag (macos: rollback linkopt flag #5684)"
- testing mac release
sluongng
force-pushed
the
sluongng/reapply-linkopt-macos
branch
11 times, most recently
from
0b65f53
to
56da2f8
Compare
This reverts commit 8bfb1c6.
sluongng
force-pushed
the
sluongng/reapply-linkopt-macos
branch
from
c1df92e
to
51754ca
Compare
|
This is a weird issue. I discussed with @brentleyjones about this and we found that GoLink on We might need to look into using a remote toolchain on MacOS instead of the host's toolchain. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.