Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make impersonation play nice with subdomains. #5004

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Make impersonation play nice with subdomains. #5004

merged 1 commit into from
Oct 12, 2023

Commits on Oct 11, 2023

  1. Make impersonation play nice with subdomains. 

    If the user is impersonating group X, but tries to access subdomain for group Y then don't enable impersonation on requests for subdomain Y so that subdomain Y can be accessed normally.

This PR slightly changes the semantics of how the frontend communicates impersonation information to the backend. Prior to this change, the frontend would set an impersonation target and would assume that impersonation was in effect.
Now, the frontend still sets the impersonation target but now the backend informs the frontend whether impersonation is actually in effect via the GetUser response.

Fixes buildbuddy-io/buildbuddy-internal#2779
    @vadimberezniker
    vadimberezniker committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    74c8c16 View commit details
    Browse the repository at this point in the history