Use streaming JSON parse for timing profile to work around V8 string size limit #4999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bduffany
changed the title
bduffany
force-pushed
the
profile-stream
branch
from
36caa32
to
d9c7e98
Compare
bduffany
force-pushed
the
rpc-service-fetch-api
branch
from
4ae4df8
to
b1d19ac
Compare
bduffany
force-pushed
the
profile-stream
branch
2 times, most recently
from
ed862f3
to
f93e429
Compare
bduffany
changed the title
bduffany
force-pushed
the
profile-stream
branch
2 times, most recently
from
2445d7c
to
ac0eab1
Compare
bduffany
force-pushed
the
profile-stream
branch
2 times, most recently
from
22cc447
to
d835aa0
Compare
siggisim
approved these changes
Oct 11, 2023
|
|
||
| let approxCompressionRatio = 1; | ||
| if (encoding === "gzip") { | ||
| approxCompressionRatio = 11.3; |
There was a problem hiding this comment.
😁
I was a little surprised that there was no way w/ the Fetch API to get the number of compressed bytes downloaded, but timing profiles should all have pretty similar compression ratio so this is probably good enough
bduffany
force-pushed
the
profile-stream
branch
8 times, most recently
from
be6d5b1
to
3ff38a2
Compare
bduffany
force-pushed
the
profile-stream
branch
from
3ff38a2
to
3a0b955
Compare
bduffany
force-pushed
the
profile-stream
branch
from
3a0b955
to
222e6ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues: N/A