Skip to content

Commit

Permalink
[Cache Proxy]: record human-readable gRPC response codes in atime-upd…
Browse files Browse the repository at this point in the history
…ater gRPC metric (#7759)

This metrics currently has values like "0" and "5." This PR switches to
using the human-readable gRPC code as the value, e.g. "OK" or
"NOT_FOUND," similar to the other gRPC graphs.
  • Loading branch information
iain-macdonald authored Oct 21, 2024
1 parent 51808b8 commit 412261e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion enterprise/server/atime_updater/atime_updater.go
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,7 @@ func (u *atimeUpdater) update(ctx context.Context, groupID string, jwt string, u
metrics.RemoteAtimeUpdatesSent.With(
prometheus.Labels{
metrics.GroupID: groupID,
metrics.StatusLabel: fmt.Sprintf("%d", gstatus.Code(err)),
metrics.StatusLabel: gstatus.Code(err).String(),
}).Inc()
if err != nil {
log.CtxWarningf(ctx, "Error sending FindMissingBlobs request to update remote atimes for group %s: %s", groupID, err)
Expand Down

0 comments on commit 412261e

Please sign in to comment.