Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👷 Implement changes for flake based deployment #456

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

phlmn
Copy link
Member

@phlmn phlmn commented Jan 14, 2025

No description provided.

@phlmn phlmn force-pushed the flake-overlay branch 5 times, most recently from 88b2bae to a4d873b Compare January 15, 2025 18:16
@phlmn phlmn changed the title flake: Add overlay output 👷 Implement changes for flake based deployment Jan 17, 2025
@phlmn phlmn changed the title 👷 Implement changes for flake based deployment 👷 Implement changes for flake based deployment Jan 17, 2025
@phlmn phlmn marked this pull request as ready for review January 17, 2025 18:03
@phlmn phlmn requested review from rroohhh, pajowu and anuejn January 17, 2025 18:03
Copy link
Member

@rroohhh rroohhh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you change the way the scripts / migrations were done?

});

nixosModules.default = {
nixpkgs.overlays = [ self.overlays.default ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we somehow get rid of the duplication in here with the packages below?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

found a way :)

@phlmn phlmn requested a review from rroohhh January 19, 2025 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants