feat: add usePageCss option, add toCanvasList and toImage method for large html #473
Conversation
…rge amount of sub nodes
|
👋 @hzsrc 💖 Thanks for opening this pull request! 💖 Please follow the contributing guidelines. And we use semantic commit messages to streamline the release process. Examples of commit messages with semantic prefixes:
Things that will help get your PR across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #473 +/- ##
==========================================
+ Coverage 62.93% 63.10% +0.17%
==========================================
Files 10 10
Lines 580 580
Branches 143 143
==========================================
+ Hits 365 366 +1
Misses 151 151
+ Partials 64 63 -1 ☔ View full report in Codecov by Sentry. |
…ed to 1px, but in <img src="svg"> it is rendered to 2px. Then height is different and the bottom 1px is lost, 10 nodes will lost 10px.
![accesslint[bot]](https://avatars.githubusercontent.com/in/1502?s=60&v=4){kind=small}
src/util.ts
Outdated
| ): Promise<string> { | ||
| const xmlns = 'http://www.w3.org/2000/svg' | ||
| const svg = document.createElementNS(xmlns, 'svg') | ||
| const foreignObject = document.createElementNS(xmlns, 'foreignObject') | ||
|
|
||
| svg.setAttribute('width', `${width}`) | ||
| svg.setAttribute('height', `${height}`) | ||
| // fix: if ratio=2 and style.border='1px', in html it is actually rendered to 1px, but in <img src="svg"> it is rendered to 2px. Then height is different and the bottom 1px is lost, 10 nodes will lost 10px. |
There was a problem hiding this comment.
This image is missing a text alternative. This is a problem for people using screen readers.
…ation of canvas size, so this can export a very large htm. And use a ``getMaxCanvasHeight` method to raise the canvas size limit from 16384 to 65535(Chrome) or 32767(Firefox)
src/util.ts
Outdated
| ): Promise<string> { | ||
| const xmlns = 'http://www.w3.org/2000/svg' | ||
| const svg = document.createElementNS(xmlns, 'svg') | ||
| const foreignObject = document.createElementNS(xmlns, 'foreignObject') | ||
|
|
||
| svg.setAttribute('width', `${width}`) | ||
| svg.setAttribute('height', `${height}`) | ||
| // fix: if ratio=2 and style.border='1px', in html it is actually rendered to 1px, but in <img src="svg"> it is rendered to 2px. Then height is different and the bottom 1px is lost, 10 nodes will lost 10px. |
There was a problem hiding this comment.
This image is missing a text alternative. This is a problem for people using screen readers.
hzsrc
changed the title
…arge amount of sub nodes
Description
Motivation and Context
Types of changes
Self Check before Merge