CI: fix Makefile not working with go 1.18

[chappjc]

go get is no longer used to install or build things. Use go install
instead. Also specify a version so the module's go.mod is not
touched when installing the CI tools.

[guggero]

LGTM 🎉

[Roasbeef]

Approved for a CI run, should be automatic after this gets in (github new contributor clause).

[Roasbeef]

I wonder if we'll run into this here? golang/go#44840

[guggero]

It looks like you need to use at least golangci-lint v1.40.0 to get this fixed. But that will require a few of the new rules that were introduced in that version to be addressed as well.

[chappjc]

I'll update the linter and fix whatever. Just a few and I'll be on it...

[chappjc]

Oh nevermind... #795 (comment)

[guggero]

Oh nevermind... #795 (comment)

Actually, I just found your PR instead that aims to fix it. So I didn't start on a PR myself.

[chappjc]

Oh, haha, let me try latest golangci-lint locally and see what needs to update.

[chappjc]

Yikes it's a LOT, at least if you use the default enabled linters.
I have a feeling most of those except perhaps errcheck, which is super annoying, are worth satisfying, but it looks to be a lot of work.

[chappjc]

But the few lint issues thrown by the current version of golangci-lint are fixed in 1d1c003 (part of #783), now cherry-picked onto this PR too

[guggero]

If a lot of errors come from the same (new) linter, I think an option might also be to disable the linter (see .golangci.yml) for now and then fix the issues in a later commit.

[chappjc]

K, lemme see how many would need to be disabled for btcwallet using golangci-ling 1.45.2, which I think is needed for go 1.18 practically

[guggero]

I tried and it looked like v1.40.0 is the oldest version that actually compiles with golang 1.18.

[chappjc]

OK wow, I'd suggest whitelisting linters (--disable-all and selective --enable) instead of the blacklisting (--enable-all and selective --disable). There are more than 20 linters (so far) that are going to be extremely difficult to satisfy.

Alternative, use the 10 default linters and add any extras you want [deadcode errcheck gosimple govet ineffassign staticcheck structcheck typecheck unused varcheck]

1.45.0 was the big go 1.18 support release and there were panics before that version. https://github.com/golangci/golangci-lint/releases/tag/v1.45.0

just some that need to be disabled

    - errlint
    - paralleltest
    - exhaustive
    - nestif
    - gocognit
    - cyclop
    - tparallel
    - testpackage
    - gci
    - errname
    - godox
    - wrapcheck
    - varnamelen
    - gomnd
    - ifshort
    - ireturn
    - nilnil
    - nlreturn
    - stylecheck
    - goerr113
    - exhaustivestruct

[Roasbeef]

Approved another CI run...

[Roasbeef]

CI looking pretty good...

[Roasbeef]

LGTM 🏉