New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Model cleanup #2

Open

jmcarp wants to merge 2 commits into bschoenfeld:master from jmcarp:model-cleanup

jmcarp commented May 27, 2018

I noticed some duplicated/unnecessary code in the postgres models. This patch deletes a bunch of code without changing behavior.

jmcarp added 2 commits

May 27, 2018 18:32


          Refactor shared model creation helpers.

bb59a3a


          Simplify table creation.

229db83

Author

jmcarp commented May 27, 2018

A few other questions about the models:

Would you be open to switching table and column names to lower-case? We have to quote upper-case table and column names now, which is a little annoying.
Is the mongodb backend still in use? It looks like all the docs reference postgres. It might make the code a bit simpler to drop mongodb entirely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet