Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version to 0.4.2 #371

Merged
merged 1 commit into from
Mar 7, 2022
Merged

Bump version to 0.4.2 #371

merged 1 commit into from
Mar 7, 2022

Conversation

abhi-agg
Copy link
Contributor

@abhi-agg abhi-agg commented Mar 7, 2022

Major Changes are:

Detailed changes here

Please feel free to update if I missed anything in the list above 👍🏾

@abhi-agg abhi-agg marked this pull request as draft March 7, 2022 12:25
@abhi-agg abhi-agg marked this pull request as ready for review March 7, 2022 12:49
Copy link
Contributor

@jerinphilip jerinphilip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abhi-agg Please keep the tags consistent at browsermt/bergamot-translator, not just push v0.4.2 to mozilla/bergamot-translator and leave here unattended like last time (v0.4.1 #356).

@abhi-agg
Copy link
Contributor Author

abhi-agg commented Mar 7, 2022

@abhi-agg Please keep the tags consistent at browsermt/bergamot-translator, not just push v0.4.2 to mozilla/bergamot-translator and leave here unattended like last time (v0.4.1 #356).

@jerinphilip I didn't get it. Didn't I push the v0.4.1 tag in this repo?

@abhi-agg abhi-agg merged commit ab7f84f into browsermt:main Mar 7, 2022
@abhi-agg abhi-agg deleted the bump-version branch March 7, 2022 17:38
@jerinphilip
Copy link
Contributor

Didn't I push the v0.4.1 tag in this repo?

[jerin@thinkpad bergamot-translator]$ git show v0.4.1
tag v0.4.1
Tagger: Jerin Philip <*****>
Date:   Sat Feb 19 08:43:29 2022 +0000

v0.4.1

commit 9eb243725bdfa8fef32225c46d4673af6f144251 (tag: v0.4.1)
Author: Abhishek Aggarwal <****>
Date:   Thu Feb 17 23:32:13 2022 +0100

    Bump version to 0.4.1 (#356)

diff --git a/BERGAMOT_VERSION b/BERGAMOT_VERSION
index fb7a04c..5aff472 100644
--- a/BERGAMOT_VERSION
+++ b/BERGAMOT_VERSION
@@ -1 +1 @@
-v0.4.0
+v0.4.1

I see that you've pushed 0.4.2, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants