[BUGFIX] Remove doubled base URL in id of list item in BreadcrumbView…

…Helper Resolves: #31
brotkrueml · Jan 30, 2020 · facf1a2 · facf1a2
1 parent cc25321
commit facf1a2
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -6,6 +6,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+### Fixed
+
+- Remove doubled base URL in id of list item in BreadcrumbViewHelper (#31)
+
 ## [1.5.0] - 2020-01-22
 
 ### Added

diff --git a/Classes/ViewHelpers/BreadcrumbViewHelper.php b/Classes/ViewHelpers/BreadcrumbViewHelper.php
@@ -105,9 +105,14 @@ public static function renderStatic(
                 $webPageTypeClass = $givenItemTypeClass ?: $webPageTypeClass;
             }
 
+            $id = $arguments[static::ARGUMENT_BREADCRUMB][$i]['link'];
+            if (\strpos($id, $siteUrl) === false) {
+                $id = $siteUrl . \ltrim($id, '/');
+            }
+
             /** @var AbstractType $itemType */
             $itemType = new $webPageTypeClass();
-            $itemType->setId($siteUrl . ltrim($arguments[static::ARGUMENT_BREADCRUMB][$i]['link'], '/'));
+            $itemType->setId($id);
 
             $item = (new ListItem())->setProperties([
                 'position' => $i + 1,

diff --git a/Tests/Unit/ViewHelpers/BreadcrumbViewHelperTest.php b/Tests/Unit/ViewHelpers/BreadcrumbViewHelperTest.php
@@ -131,6 +131,23 @@ public function fluidTemplatesProvider(): iterable
             ],
             '<script type="application/ld+json">{"@context":"http://schema.org","@type":"BreadcrumbList","itemListElement":{"@type":"ListItem","item":{"@type":"WebPage","@id":"https://example.org/videos/unicorns-in-typo3-land/"},"name":"Unicorns in TYPO3 land","position":"1"}}</script>',
         ];
+
+        yield 'Breadcrumb item with an absolute URL as link given' => [
+            '<schema:breadcrumb breadcrumb="{breadcrumb}"/>',
+            [
+                'breadcrumb' => [
+                    [
+                        'title' => 'A web page',
+                        'link' => '/',
+                    ],
+                    [
+                        'title' => 'Unicorns in TYPO3 land',
+                        'link' => 'https://example.org/videos/unicorns-in-typo3-land/',
+                    ],
+                ],
+            ],
+            '<script type="application/ld+json">{"@context":"http://schema.org","@type":"BreadcrumbList","itemListElement":{"@type":"ListItem","item":{"@type":"WebPage","@id":"https://example.org/videos/unicorns-in-typo3-land/"},"name":"Unicorns in TYPO3 land","position":"1"}}</script>',
+        ];
     }
 
     /**