Add note about grpmax #1290
Merged
Add note about grpmax #1290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bout group with highest FAF, not FAF calculated on group with highest AF
klaricch
requested changes
Nov 14, 2023
| @@ -9,10 +9,4 @@ Note that this annotation contains filtering allele frequency information from t | |||
|
|
|||
There was a problem hiding this comment.
"Note that this annotation contains filtering allele frequency information from the genetic ancestry group with the highest FAF"
We should clarify that this part is referring to the grpmax faf (or whatever we settled on for a name) and not just faf
There was a problem hiding this comment.
will add a sentence -- let me know what you think
There was a problem hiding this comment.
L8: "this annotation" -> " the GroupMax FAF"
browser/help/topics/faf.md
Outdated
| This annotation (abbreviated "`grpmax`") contains allele frequency information (AC, AN, AF, homozygote count) for the non-bottlenecked genetic ancestry groups with the highest **AF**. | ||
|
|
||
| For gnomAD v4, this calculation excludes Amish (`ami`), Ashkenazi Jewish (`asj`), European Finnish (`fin`), Middle Eastern (`mid`), and "Remaining Individuals" (`rmi`) groups. For gnomAD v2, this calculation excludes Ashkenazi Jewish (`asj`), European Finnish (`fin`), and "Remaining Individuals" (`rmi`) groups. | ||
| On the browser, this annotation is directly available on the variant page. In the VCF and Hail Tables, this annotation (abbreviated "`faf`") is computed globally and for each genetic ancestry group. Filtering allele frequencies (FAFs) for each genetic ancestry group specific are listed separately with 95% and 99% CIs. |
There was a problem hiding this comment.
should clarify that grpmax faf is on the brower, but all faf is in the Tables
or maybe change the id to grpmax faf and edit some of the text?
Co-authored-by: klaricch <[email protected]>
klaricch
requested changes
Nov 14, 2023
| @@ -9,10 +9,4 @@ Note that this annotation contains filtering allele frequency information from t | |||
|
|
|||
There was a problem hiding this comment.
L8: "this annotation" -> " the GroupMax FAF"
klaricch
approved these changes
Nov 15, 2023
rileyhgrant
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added note that grpmax does not contain filtering allele frequency. Looking at this again, should we just remove grpmax text from the faf md?