Upgrade mocha and package lock for security warning #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdeitte
commented
Sep 14, 2024
| @@ -16,6 +16,8 @@ includes all changes in the latest node-statsd and many additional changes, incl | |||
| * asyncDistTimer | |||
| * much more, including many bug fixes | |||
|
|
|||
| You can read about all changes in [the changelog](CHANGES.md). | |||
|
|
|||
There was a problem hiding this comment.
One of the most helpful files in the project as it's kept well up to date, so moving it earlier. And removing two sections that just feel dated below.
bdeitte
commented
Sep 14, 2024
package-lock.json
Outdated
| @@ -1,222 +1,279 @@ | |||
| { | |||
| "name": "hot-shots", | |||
| "version": "10.1.1", | |||
| "lockfileVersion": 1, | |||
| "lockfileVersion": 3, | |||
There was a problem hiding this comment.
And now obvious why the tests are failing, still supporting very old Node versions here. I'll fix up this PR later for this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the non-dev dependencies to fix security warning. Also a few misc README updates.