Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(secrets): Remove both random and base64 entropy secrets finding #6969

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

pazbechor
Copy link
Contributor

@pazbechor pazbechor commented Jan 24, 2025

User description

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

New/Edited policies (Delete if not relevant)

Description

Include a description of what makes it a violation and any relevant external links.

Fix

How does someone fix the issue in code and/or in runtime?

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes

Generated description

Below is a concise technical summary of the changes proposed in this PR:

Modifies the secret detection logic to remove duplicate entropy-based findings. Enhances the CustomRegexDetector class to better handle multiline regex matches and updates the SecretsRunner to prioritize Random High Entropy findings over Base64 High Entropy findings on the same line.

TopicDetails
Regex Matching Enhances the CustomRegexDetector class to better handle multiline regex matches
Modified files (1)
  • checkov/secrets/plugins/custom_regex_detector.py
Latest Contributors(2)
UserCommitDate
omryMenfix-secrets-fix-find-l...November 21, 2024
RabeaZrfix-secrets-multiline-...November 21, 2024
Entropy Detection Improves the handling of entropy-based secret detection to reduce duplicate findings
Modified files (1)
  • checkov/secrets/runner.py
Latest Contributors(2)
UserCommitDate
[email protected]feat-secrets-Masking-s...November 17, 2024
[email protected]feat-secrets-Adding-ch...November 17, 2024
This pull request is reviewed by Baz. Join @pazbechor and the rest of your team on (Baz).

pazbechor added 2 commits January 24, 2025 15:34
… (in multiline policy) captured, so matching group will be the match & empty matching as only one pattern caught the secret
@tsmithv11 tsmithv11 changed the title fix(secrets) Remove both random and base64 entropy secrets finding fix(secrets): Remove both random and base64 entropy secrets finding Jan 24, 2025
@Saarett
Copy link
Contributor

Saarett commented Jan 27, 2025

Great work @pazbechor ! Do we have any relevant tests that needs to be changed/added?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants