Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Derive SecureRandom for SystemRandom on Fuchsia #2152

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

erickt
Copy link
Contributor

@erickt erickt commented Oct 1, 2024

The getrandom::getrandom on Fuchsia uses zx_cprng_draw to get cryptographically secure random data, which can be seen here.

The `getrandom::getrandom` on Fuchsia uses `zx_cprng_draw` to get cryptographically secure random data, which can be seen [here](https://github.com/rust-random/getrandom/blob/master/src/fuchsia.rs).
Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.12%. Comparing base (25cc803) to head (4ada633).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2152      +/-   ##
==========================================
+ Coverage   96.96%   97.12%   +0.15%     
==========================================
  Files         151      149       -2     
  Lines       19597    19536      -61     
  Branches      468      465       -3     
==========================================
- Hits        19002    18974      -28     
+ Misses        487      460      -27     
+ Partials      108      102       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@briansmith briansmith merged commit f291606 into briansmith:main Oct 4, 2024
144 of 145 checks passed
@briansmith
Copy link
Owner

Thanks!

@erickt erickt deleted the patch-1 branch October 17, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants