Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

retain search term on input blur unless it is empty #66

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jonathan-reisdorf
Copy link
Contributor

No description provided.

@spolu
Copy link
Member

spolu commented Oct 2, 2014

Cool! I'll test it today thoroughly and will merge it!

@spolu
Copy link
Member

spolu commented Oct 2, 2014

Unfortunately this does not work very well with the auto-filtering of tabs. If I filter tabs and then go to one, it should clear the input otherwise I'm bound to click or hit Ctrl-L and hit escape to make my tabs reappear...

@jonathan-reisdorf
Copy link
Contributor Author

Yes, that's what I was concerned about in bug #53
Do you have any best practise to achieve this behavior?

@spolu
Copy link
Member

spolu commented Oct 2, 2014

I guess this is the price to pay to have tabs filtering...

@jonathan-reisdorf
Copy link
Contributor Author

I have just committed a solution here. I'm not sure if it's the best one, but definitely working

@spolu
Copy link
Member

spolu commented Oct 2, 2014

Well the search text still sticks around when using keyboard shortcuts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants