Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Internationalization Support for Leo (uplift to 1.72.x) #26126

Open
wants to merge 1 commit into
base: 1.72.x
Choose a base branch
from
Open

Internationalization Support for Leo (uplift to 1.72.x) #26126

wants to merge 1 commit into from
+327 −130

Conversation

bbondy
Copy link
Member

@bbondy bbondy commented Oct 21, 2024

Not quite ready for uplift yet, please hold up. Need to make sure CI is clean after a merge conflict. I will edit this description when it's ready.

Uplift of #25931
Resolves brave/brave-browser#41554

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@bbondy
Internationalization Support for Leo (#25931)
184f222 
Brave browser sends up a `selected_language` and a `system_language` with prompts.
The `selected_language` is initially an empty string, but the server can
send a SelectedLanguage event to set the language for future.
The server sets a selected_language based on what it detects the first
message's language to be in.  If it can't make that determine or that
message is not long enough it can fallback to using the system language.
Or if there is no system language specified it will use English.

More details here:
https://docs.google.com/document/d/1IWQNX-E40ujaQFQVavZEtgK3J068PgZ_xDbSLDWZOD8/edit?tab=t.0#heading=h.miolul91b7va
@bbondy bbondy added this to the 1.72.x - Beta milestone Oct 21, 2024
@bbondy bbondy requested a review from a team as a code owner October 21, 2024 19:57
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Oct 21, 2024
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@kjozwiak
Copy link
Member

@bbondy please remove the Uplift/Blocked label when the above is ready to be uplifted into 1.72.x 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bbondy bbondy

Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build Uplift/Blocked
Projects
None yet
Milestone
1.72.x - Beta
Development

Successfully merging this pull request may close these issues.
3 participants
@bbondy @brave-builds @kjozwiak