Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dumps to debug empty shields settings in v8 workers. #26115

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Conversation

goodov
Copy link
Member

@goodov goodov commented Oct 21, 2024

Most crashes was fixed with the previous PR. Right now we see only worker-related crashes.

This PR prevents these crashes and adds some diagnostics to figure where things go wrong.

Resolves brave/brave-browser#41724

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@goodov goodov marked this pull request as ready for review October 21, 2024 13:11
@goodov goodov requested a review from a team as a code owner October 21, 2024 13:11
@goodov goodov requested a review from iefremov October 21, 2024 13:11
@goodov goodov merged commit d744024 into master Oct 22, 2024
20 checks passed
@goodov goodov deleted the issues/41724 branch October 22, 2024 09:10
@github-actions github-actions bot added this to the 1.73.x - Nightly milestone Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash in brave::BraveSessionCache::GetBraveFarblingLevel strikes again
2 participants