Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add twine check job #280

Merged
merged 2 commits into from
Oct 6, 2024
Merged

Conversation

cdce8p
Copy link
Contributor

@cdce8p cdce8p commented Oct 6, 2024

Saw these warning in the Github actions log:

Checking dist/ephem-4.1.6-cp312-cp312-manylinux_2_17_x86_64.manylinux2014_x86_64.whl: PASSED with warnings
WARNING  `long_description_content_type` missing. defaulting to `text/x-rst`.

Added long_description_content_type and a twine check job to detect issue earlier.

Aside from that, I believe you'll need to set up 2FA. That's the reason the previous deploy failed.
https://github.com/brandon-rhodes/pyephem/actions/runs/11204069272/job/31142468359

@brandon-rhodes
Copy link
Owner

I went and set up 2FA, and then hit the big "retry" button on the upload step. Fingers crossed —

@cdce8p
Copy link
Contributor Author

cdce8p commented Oct 6, 2024

This is ready now as well. Will be useful to have for the future.

@brandon-rhodes brandon-rhodes merged commit 28f746a into brandon-rhodes:master Oct 6, 2024
6 checks passed
@brandon-rhodes
Copy link
Owner

Thanks!

@cdce8p cdce8p deleted the twine-check branch October 6, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants