Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ThreeDSecureLauncher Constructor #877

Merged
merged 2 commits into from
Jan 4, 2024
Merged

Update ThreeDSecureLauncher Constructor #877

merged 2 commits into from
Jan 4, 2024

Conversation

sarahkoop
Copy link
Contributor

Summary of changes

  • Update ThreeDSecureLauncher constructor to take more generic ComponentActivity rather than FragmentActivity (we don't use any FragmentActivity specific attributes and ComponentActivity is more compose-compatible)
  • Update doc strings for ThreeDSecureLauncher public methods

Checklist

  • [ ] Added a changelog entry

Authors

@sarahkoop sarahkoop requested a review from a team as a code owner January 4, 2024 18:30
@sarahkoop sarahkoop merged commit 1348e8c into v5 Jan 4, 2024
3 checks passed
@sarahkoop sarahkoop deleted the 3ds_launcher_activity branch January 4, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saperi22 saperi22 saperi22 approved these changes

@sshropshire sshropshire sshropshire approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sarahkoop @sshropshire @saperi22